Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double entries / filter by installed #53

Closed
Sir-Photch opened this issue Dec 13, 2022 · 3 comments · Fixed by #55
Closed

Double entries / filter by installed #53

Sir-Photch opened this issue Dec 13, 2022 · 3 comments · Fixed by #55
Labels
bug Something isn't working research-needed

Comments

@Sir-Photch
Copy link
Contributor

Sir-Photch commented Dec 13, 2022

Hi!

This is a pretty cool TUI for steam, I gotta be honest.
Two things that appeared to me though:

I get multiple entries for the same game, if they are installed:
grafik

Is this an issue of your implementation?

Also, would it be possible to add a filter to only show installed games? Would make things easier for ppl with larger libraries.

I know some rust, so If you point me to the right places, I might be able to modify that myself.

Cheers!

@dmadisetti
Copy link
Owner

Does this solve your issue? https://github.com/dmadisetti/steam-tui#hiding-games

If the entries have different ida, then it's a steam thing. Let me know if they have the same id

@dmadisetti dmadisetti added bug Something isn't working research-needed labels Dec 13, 2022
@dmadisetti
Copy link
Owner

I saw your branch, does this seem to work?
Sir-Photch@d27c561

If you create a PR I'll merge it

@Sir-Photch
Copy link
Contributor Author

Sir-Photch commented Dec 23, 2022

There are no duplicates anymore, but launching games does not work properly on my machine. Maybe you have a try and see if it still works for you? I am not sure whether this is a breaking change or it's just an issue with my system.

Maybe this duplicate problem is somehow related to proton games? Because in the image atop, CK3 supports Linux natively iirc, but Doom and DRG don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working research-needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants