using s(0) instead of hardcoded s0 #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its more maintainable (changing the definition of s breaks things without this change).
Note: I don't know what ```generateCacheFooter('s0')``` does and the s0 in there looks suspicious to me
|
Thanks for the patch. I modified it slightly to conform to code conventions used in PEG.js (spaces around |
Sciumo
pushed a commit
to Sciumo/pegjs
that referenced
this pull request
Jan 2, 2014
Based on a patch by @fresheneesz: pegjs#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its more maintainable (changing the definition of s breaks things without this change).
Note: I don't know what
generateCacheFooter('s0')does and the s0 in there looks suspicious to me