Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine trim_adjacency_matrix with construct_graph #1

Open
dmarx opened this issue Aug 5, 2014 · 0 comments
Open

combine trim_adjacency_matrix with construct_graph #1

dmarx opened this issue Aug 5, 2014 · 0 comments
Assignees

Comments

@dmarx
Copy link
Owner

dmarx commented Aug 5, 2014

Ultimately, we just iterate through the condensed adjacency matrix anyway. Instead of creating a (potentially very expensive) copy, modify the conditional test in construct_graph to test if an entry is below the 'r' threshold instead of testing if the entry is non-zero.

All we need to do is add r and rq as parameters to construct_graph and move the chunk that calculates r from rq to the top of construct_graph.

The result should be moderately faster (the real bottleneck in the code is the pdist call) and much more memory efficient.

@dmarx dmarx self-assigned this Aug 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant