-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashes reported for 271ef97 #22
Comments
Could not reproduce on my NetBSD-CURRENT'13. |
I know of it and it stated at line 137 of README in wulf7/integrate-dmatveev branch:
Most probably it started with commit 9d09b2c I can tell you whats going on here in details but not just now due to ENOTIME. Maybe tomorrow or in a few days Do you now any practical use of running inotify with IN_EXCL_UNLINK flag unset? P.S. And it not crashes for me. Just sends IN_IGNORE and stops watching as intended |
Hmm. Are you asked about crash or about inability of receiving events from deleted but still opened files? |
Ooops. Sorry. I misunderstood a code in test case. My comment is correct but irrelevant to issue |
Hi Vladimir, glad to hear from you. Actually, there was an e-mail thread and you had been put into copy, though Mikhail (the reporter) said that messages are not delivered to you. Can you please recheck? Mikhail reported that after commit 271ef97 (where some loops were modified as in This test should prove that, though I failed to reproduce anything, I am trying to get more details now. |
Got it! Try following patch: diff --git a/worker-sets.c b/worker-sets.c
index 504b8cf..442adf5 100644
--- a/worker-sets.c
+++ b/worker-sets.c
@@ -83,7 +83,6 @@ worker_sets_extend (worker_sets *ws,
return -1;
}
ws->watches = ptr;
- ws->watches[0] = NULL;
ws->allocated = to_allocate;
} |
Unfortunately, my personal mail server lost rackspace in datacentre about month ago so I cant respond on any mails till I find another place for it |
One should set a watch on directory with number of entries more than WS_RESERVED (10) to trigger this issue. That`s why it was not discovered with test suite |
Really, the issue was there. Thanks! BTW, how do you debug libinotify? I do not remember if I had any issues four years ago, but in my current NetBSD installations I just can not hook into library's functions with gdb for step-by-step debugging (it can not find any debug symbols), though all flags required for that are present. |
I replace -DNDEBUG with -DDEBUG in Makefile.am to enable assertions then set environment variables CFLAGS=-g -O0 CXXFLAGS=-g -O0 before configure stage to add debugging info and then run configure with --enable-perrors. Sometimes I run tests under valgrind control but not very often as it requires some level of source patching to workaround some valgrind porting deficiencies and FreeBSD lpthread bugs |
The following program crashes with the recent changes in libinotify, though it works fine on GNU/Linux:
The text was updated successfully, but these errors were encountered: