Tests use classes instead of objects #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like the change, could you just bring it up to date on your fork? |
JUnit 5 does some reflectomagic to violate Java visibility rules when instantiating test classes, and so breaks the singleton-ness of Kotlin objects.
npryce
force-pushed
the
tests-use-classes-instead-of-objects
branch
from
6ba7ca0
to
67a74bb
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit 5 uses reflectomagic to instantiate test classes, which means that
it instantiates multiple instances of an object's class, violating its
singleton-ness. Therefore it's safer to define tests in classes.