New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pycp crashes when file size changes during transfer #15

Closed

ghost opened this issue Mar 26, 2016 · 0 comments

Milestone

ghost commented Mar 26, 2016

If the file size increases while it's being transferred, pycp may crash with an assertion failure here

def on_file_transfer():
    self.global_pbar.update(xferd) 

def fraction()
    res = float(curval) / maxval
    assert res > 0
    assert res < 1
    return res

We can't really assume that xferd will always be smaller than src file size !

dmerejkowsky pushed a commit that referenced this issue


          Remove buggy assertion (#15)

affd825

ghost added this to the v7 milestone

dmerejkowsky closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment