Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for handling discrete quantities #9

Merged
merged 5 commits into from Nov 10, 2020
Merged

Add support for handling discrete quantities #9

merged 5 commits into from Nov 10, 2020

Conversation

dmey
Copy link
Owner

@dmey dmey commented Nov 9, 2020

Introduces the option to specify and model discrete quantities as follows:

# Assuming  an xarray datasets ds with X1 discrete and and X2 continuous 
generator.fit(ds, copula=syn.VineCopula(controls=ctrl), is_discrete={'X1': True, 'X2': False})

This option is only supported for vine copulas

@dmey dmey requested a review from tnagler November 9, 2020 22:02
tnagler
tnagler requested changes Nov 10, 2020
View reviewed changes
Copy link
Collaborator

@tnagler tnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except the column ordering

@dmey dmey requested a review from tnagler November 10, 2020 20:35
@dmey dmey merged commit 3261b51 into master Nov 10, 2020
@dmey dmey deleted the dmey/discrete branch November 10, 2020 20:40
@dmey dmey added this to the 0.2.0 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnagler tnagler tnagler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmey @tnagler