-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatched data #13
Comments
@BehindTheMath fell free to make pull request |
PST is "pacific standard time" but here it says "pakistan standard Time" |
When isdst=true, abbr and offset follow. |
pakistan standard Time should be PKT |
I think it should have been abbr_dst and offset_dst. |
@dmfilipenko How about if we would change the format to something like this: interface TimezoneDetails {
value: string;
abbr: string;
offset: number;
text: string;
}
export interface Timezone extends TimezoneDetails {
dst: TimezoneDetails | false | null;
utc: string[];
} Here's an example of what it would look like: {
"value": "Eastern Standard Time",
"abbr": "EST",
"offset": -5,
"text": "(UTC-05:00) Eastern Time (US & Canada)",
"dst": {
"value": "Eastern Daylight Time",
"abbr": "EDT",
"offset": -4,
"text": "(UTC-04:00) Eastern Time (US & Canada)",
},
"utc": [
"America/Detroit",
"America/Havana",
"America/Indiana/Petersburg",
"America/Indiana/Vincennes",
"America/Indiana/Winamac",
"America/Iqaluit",
"America/Kentucky/Monticello",
"America/Louisville",
"America/Montreal",
"America/Nassau",
"America/New_York",
"America/Nipigon",
"America/Pangnirtung",
"America/Port-au-Prince",
"America/Thunder_Bay",
"America/Toronto",
"EST5EDT",
],
},
{
"value": "Venezuela Standard Time",
"abbr": "VST",
"offset": -4.5,
"text": "(UTC-04:30) Caracas",
"dst": false,
"utc": [
"America/Caracas",
],
}, The This would be a breaking change, and would require a major version bump. |
@BehindTheMath This is a huge change. Unfortunately, I don't have much time to do this |
I might do it myself and submit a PR. What do you think of such a schema? |
@BehindTheMath from a first view it might be useful. But what if we wouldn't make a nested object and add another timezone
I prefer to left this structure a flat |
@dmfilipenko My issue with that way is that there's no relationship between standard and daylight timezones. So if I have one, there's no easy way to get the other. |
@BehindTheMath I was thinking about and seemed like it is reasonable. Lets try to do this |
@BehindTheMath any progress on this? This is so close to what we need |
I kind of gave up on it and started using Luxon instead. |
It looks like for many of the timezones, the
value
andtext
properties reflect the values for standard time, whereas theabbr
andoffset
properties refect the values for DST.For example, for
Eastern Standard Time
,value === 'Eastern Standard Time'
andtext
has an offset ofUTC-05:00
, which are the correct values for standard time. However,offset === -4
, andabbr === 'EDT'
, which stands forEastern Daylight Time
.The text was updated successfully, but these errors were encountered: