-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page layout #1
Comments
Glad you're liking the app! I also used to be a Marvin user. I built Inkwell because I wanted more customizability. When I originally built the app, I intended to add pagination. However, due to the way the rendering engine works, it turns out this is an incredibly difficult feature to add. Doing so would break image rendering, text highlighting, and text styles. An alternative solution I've been considering is fake pagination. This means the page would still use a scroll layout, but clicking on the sides of the screen would automatically scroll the page up or down by a page height. What are your thoughts on that? |
ah, that's too bad pagination is so hard to implement... Very frustrating I can imagine. I think "jumping" should be ok, but I would recommend disabling the ability to scroll by dragging fingers on the screen (if that's possible), otherwise I will fat finger it I am sure and be completely lost. |
Makes sense! Thanks for the feedback. I'll include jumping pagination in the next update! |
Just rolled out an update with support for pagination as well as a few other fixes. You'll find it in the Layout menu. It's still a bit rough, but hopefully it aligns with what you were looking for. |
woah, that was fast. I just tested it, it works perfectly for me, thanks! I think a progress indicator somewhere would be nice too. With percentage or something like this. The vertical margins should also be configured in a way that 0 means nothing is cut. At the moment, 0 means the text is "behind" the notch in my case, for example. But these are new feature requests anyway. |
There already are progress bars! There’s 2 of them actually. The first is the circle next to the title on the library screen. The second is in the settings menu in the book. It’s the little gray line that sits under the title bar. Personally, I like having the text fall behind the notch as I scroll, but I see how that’s not a great feature in paginated mode. I’ll add a toggle to disable notch space use. |
Ah, right, didn't see it, I only tested around and was always at the very stat of the free ebooks which are included, so I did not notice these progress bars. Great, thanks. |
Pagination margins issue is fixed as well. Now, in paginated mode, content no longer flows into the “safe areas” like the notch and curved part of the screen. I think you were right. It makes it a lot easier to keep track of your spot with it set up this way. |
Impressive. I didn't know one could get approved so fast by apple, I had in mind it took a week or more... |
Yeah I’ve got no idea what’s up with that. It definitely used to take at least a week. Maybe it’s due to the app category? |
Hello,
I like the app a lot, especially the ability to remove margins entirely, which is quite useful on smaller screens. So far I had only found the Marvin app which was able to do this.
I was wondering is there a way in the app to read page by page instead of continuous scrolling. I cannot figure out how to do it so far, maybe I'm missing something.
The text was updated successfully, but these errors were encountered: