Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show selected notes on fretboard #2

Open
tomasz13 opened this issue Mar 11, 2020 · 2 comments
Open

Show selected notes on fretboard #2

tomasz13 opened this issue Mar 11, 2020 · 2 comments

Comments

@tomasz13
Copy link

it would be nice to see every selected notes on the fretboard visualisation...

something like this:
selectednotes

thank you

@srghma
Copy link

srghma commented Nov 22, 2021

does show when selecting several intervals

2021-11-22-02pm-00-59-screenshot
2021-11-22-02pm-01-01-screenshot

but not when I pick 2 note

2021-11-22-02pm-01-17-screenshot
2021-11-22-02pm-01-20-screenshot

@dmitrio95
Copy link
Owner

Indeed, the case of a range selection was implemented recently in 35c84dc, so the plugin now displays all notes in a range selection. Maybe this should be extended for a non-range selection containing multiple notes.

I wonder what would be the expected behavior though: if one note is selected the fretboard displays its entire chord (which is expected for using the fretboard widget as a note input tool). Does this mean that if two notes are selected then both chords should be displayed on the fretboard? Or just these two notes? And what is the scenario when such handling of multiple notes selection is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants