Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling #91

Closed
domergal16 opened this issue Apr 6, 2022 · 5 comments
Closed

Fix compiling #91

domergal16 opened this issue Apr 6, 2022 · 5 comments

Comments

@domergal16
Copy link

I had trouble getting this package to install, and have realized that if line 55 in setup.py is changed from:
self.cmake_args or "--",
to
self.cmake_args or "-S",

then multicore-TSNE compiles correctly. If this change could be made, that'd be awesome!

@jorvis
Copy link
Collaborator

jorvis commented Apr 29, 2022

This is fixed with this pull request (if it gets accepted):

#92

@6884
Copy link

6884 commented Jul 20, 2022

THANK YOU!!! this solved my issue as well!

@r614
Copy link

r614 commented Aug 19, 2022

@DmitryUlyanov thoughts on merging the fix above? PyPi installations are broken with the latest cmake, and downgrading for this library conflicts with other up-to date dependencies.

@JackingChen
Copy link

this also solved my issue!

@kulibour
Copy link

kulibour commented May 10, 2023

THANK YOU!!!
It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants