This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
Add Apple Sign In #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@json469 Thank you for the PR. Apologies I've not got to it yet, life has suddenly got very busy. I will review this very soon. |
|
Thanks for the PR @json469 . This is one part that is now - since Apple enforces Sign in with Apple since a few days for new apps - crucial for Flutter apps. |
|
Apologies for the long delay. This will be merged via #17. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds apple sign in button built according to the official guidelines - https://developer.apple.com/design/human-interface-guidelines/sign-in-with-apple/overview/ - some details were inexplicit and had to be estimated.
Also, the example main.dart now has a container of SingleScrollChildView to prevent devices with smaller screens to overflow.