Build for CPU only

[xianyi]

Now, the minerva can build on CPU only.

I added SigmoidForward, ReluForward, and TanhForward CPU basic implementation.
For apps, the minst_mlp works fine.

To-do:

• other CPU implementations including conv, backward...

[hotpxl]

Better be float* data.

[hotpxl]

Thanks for contributing to the feature for building on CPU only. We currently don't have support for convolution operators on CPU, but that, of course, is something we want in the future. Although performance on CPU only machines might be poor, but we can still offer our easy-to-use interface.

As to contributing C++ code, please comply by Google C++ Style Guide standard for easy maintenance and readability, especially the formatting part. I have put some comment on the files for your reference. I fully acknowledge the pain to follow someone else's rules. But we will benefit from a uniform coding convention at last.

For the unit tests, I think it's better not to put macros in them to cater to CPU or GPU instances. It would be better to create unit tests for CPU and GPU operators, and use macros to stop the GPU tests from compiling if the machine does not have CUDA.

Thanks for your effort!

[hotpxl]

Could we do something like in unittest_elewise.cpp to create separate tests, and disable GPU ones using the macro HAS_CUDA?

[xianyi]

@hotpxl,

Thank you for the suggestion. I will fix the coding style and unittest issue.

I plan to support convolution operators on CPU by CPU BLAS functions.

[xianyi]

@hotpxl ,
Please review the patch. I already fixed issues.

[hjk41]

Should we have a "OpenBLAS" implementation, instead of reusing the "basic"?
I think "basic" should be used only for validation, and does not depend on
any other library. What do you think?

On Mon, Dec 22, 2014 at 2:33 AM, Zhang Xianyi notifications@github.com
wrote:

@hotpxl https://github.com/hotpxl ,
Please review the patch. I already fixed issues.

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

HONG Chuntao
System Research Group
Microsoft Research Asia

[xianyi]

If you don't want basic depending other library, including OpenBLAS. I can
just write a three-loops gemm implementation.

2014-12-22 10:03 GMT+08:00 hjk41 notifications@github.com:

Should we have a "OpenBLAS" implementation, instead of reusing the
"basic"?
I think "basic" should be used only for validation, and does not depend on
any other library. What do you think?

On Mon, Dec 22, 2014 at 2:33 AM, Zhang Xianyi notifications@github.com
wrote:

@hotpxl https://github.com/hotpxl ,
Please review the patch. I already fixed issues.

—
Reply to this email directly or view it on GitHub
<
https://github.com/minerva-developers/minerva/pull/2#issuecomment-67779564>

.

HONG Chuntao
System Research Group
Microsoft Research Asia

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

[hjk41]

Let's use hand-written functions for "basic" and create an "OpenBLAS" implementation.

[hotpxl]

Thanks!