Skip to content
This repository has been archived by the owner on Oct 15, 2019. It is now read-only.

Code style refinement to solve pylint error #77

Closed
lryta opened this issue Nov 15, 2016 · 6 comments
Closed

Code style refinement to solve pylint error #77

lryta opened this issue Nov 15, 2016 · 6 comments

Comments

@lryta
Copy link
Member

lryta commented Nov 15, 2016

@HrWangChengdu fixed pylint on travis. Could @hotpxl have a look at his Pylint options to check if the current configuration fits our project? (Do we need to turn on all the pylint options?)

After the confirmation of pylint options, we may distribute the work to fix the pylint error.

@jermainewang
Copy link
Member

I think some lint options are too strict. I'm modifying the lint check and turn off some unnecessary ones.

@jermainewang
Copy link
Member

Here are the lint error categories:

  • invalid-name
  • missing-docstring
  • empty-docstring
  • unidiomatic-typecheck
  • line-to-long
  • trailing-whitespace
  • trailing-newlines
  • multiple-statements (on single line)
  • bad-whitespace
  • bad-continuation
  • multiple-imports
  • wrong-import-order
  • wrong-import-position
  • no-self-argument
  • import-error
  • undefined-variable
  • no-member
  • dangerous-default-value
  • pointless-statement
  • pointless-string-statement
  • expression-not-assigned
  • exec-used
  • attribute-defined-outside-init
  • protected-access
  • arguments-differ
  • abstract-method
  • super-init-not-called
  • unnecessary-semicolon
  • bad-indentation
  • deprecated-module
  • fixme
  • unused-import
  • unused-variable
  • unused-argument
  • redefined-outer-name
  • redefined-builtin
  • undefined-loop-variable
  • cell-var-from-loop
  • bare-except
  • broad-except
  • logging-format-interpolation
  • deprecated-method

I think most of them should be fixed. Here are some exceptions:

  • fixme should be allowed.
  • protected-member and invalid-name could be disabled locally.

What do you guys think? @hotpxl @lryta @HrWangChengdu

@lryta
Copy link
Member Author

lryta commented Nov 28, 2016

I agree with your proposal @jermainewang

@Taco-W
Copy link
Member

Taco-W commented Nov 28, 2016

I agree @jermainewang . I suggest we start working in this rule and give feedbacks if other exceptions are found to be necessary later.

@hotpxl
Copy link
Member

hotpxl commented Nov 28, 2016

I agree. Mandatory checks may be less strict but we could still recommend more strict checks for developers.

@jermainewang
Copy link
Member

Solved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants