Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

A single space, a BUG? #93

Closed
zhangchen-qinyinghua opened this issue Jan 13, 2016 · 3 comments
Closed

A single space, a BUG? #93

zhangchen-qinyinghua opened this issue Jan 13, 2016 · 3 comments

Comments

@zhangchen-qinyinghua
Copy link
Contributor

Check the code here,

https://github.com/dmlc/mshadow/blob/master/mshadow/tensor_blob.h#L320

is different from code here,

https://github.com/dmlc/mshadow/blob/master/mshadow/tensor_cpu-inl.h#L40

there is a small space after the comma.
I think that will give rise to some troubles.

For example, if I use:

TShape shape=mshadow::Shape2(5,5);
std::stringstream ss;
string s;
ss<<shape;
ss>>s;
//s is (5,
@zhangchen-qinyinghua
Copy link
Contributor Author

It's not big deal, but will make some behaviors confusing.

@tqchen
Copy link
Member

tqchen commented Jan 13, 2016

oh, thanks for pointing this out, let us make it consistent, can you submit a pr?

@zhangchen-qinyinghua
Copy link
Contributor Author

@tqchen
Sure, I am glad to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants