Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

/rnn/char_lstm notebook example is broken #1116

Closed
recastrodiaz opened this issue Dec 30, 2015 · 2 comments
Closed

/rnn/char_lstm notebook example is broken #1116

recastrodiaz opened this issue Dec 30, 2015 · 2 comments

Comments

@recastrodiaz
Copy link
Contributor

I found a few issues while trying to run this notebook:

  • the learning rate is too big, leading to NRR=Infinity and Prep=Infinity
  • the optimizer was changed from 'sgd' to 'rmsprop', but the hyperparameters were not updated: there is no 'momentum' hyperparameter in rmsprop.
  • the 'input.txt' file is not automatically downloaded when running the ./get_ptb_data.sh script
  • the script get_ptb_data.sh script should use #!/usr/bin/env

I'll create a PR to fix the issues above.
recastrodiaz added a commit to recastrodiaz/mxnet that referenced this issue Dec 30, 2015
@recastrodiaz
Fix issue apache#1116
3b8897e 
- the learning rate is too big, leading to NRR=Infinity and Prep=Infinity
- the optimizer was changed from 'sgd' to 'rmsprop', but the hyperparameters were not updated: there is no 'momentum' hyperparameter in rmsprop.
- the 'input.txt' file is not automatically downloaded when running the ./get_ptb_data.sh script
- the script get_ptb_data.sh script should use [#!/usr/bin/env](http://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my)
recastrodiaz added a commit to recastrodiaz/mxnet that referenced this issue Dec 30, 2015
@recastrodiaz
Fix issue apache#1116
b81dda0 
- the learning rate is too big, leading to NRR=Infinity and Prep=Infinity
- the optimizer was changed from 'sgd' to 'rmsprop', but the hyperparameters were not updated: there is no 'momentum' hyperparameter in rmsprop.
- the 'input.txt' file is not automatically downloaded when running the ./get_ptb_data.sh script
- the script get_ptb_data.sh script should use [#!/usr/bin/env](http://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my)
recastrodiaz added a commit to recastrodiaz/mxnet that referenced this issue Dec 30, 2015
@recastrodiaz
Fix issue apache#1116
aa82d39 
- the learning rate is too big, leading to NRR=Infinity and Prep=Infinity
- the optimizer was changed from 'sgd' to 'rmsprop', but the hyperparameters were not updated: there is no 'momentum' hyperparameter in rmsprop.
- the 'input.txt' file is not automatically downloaded when running the ./get_ptb_data.sh script
- the script get_ptb_data.sh script should use [#!/usr/bin/env](http://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my)
@recastrodiaz
Copy link
Contributor Author

PR available here: #1117
Let me know if I should change anything else. Thx!

mli added a commit that referenced this issue Dec 31, 2015
@mli
Merge pull request #1117 from recastrodiaz/fix_char_lstm_example
0927a28 
Fix issue #1116
@mli
Copy link
Member

mli commented Dec 31, 2015

merged, many thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mli @recastrodiaz