Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing lines in relay types doc #3890

Closed
vmiheer opened this issue Sep 4, 2019 · 3 comments

Comments

@vmiheer
Copy link
Contributor

commented Sep 4, 2019

Hi I ma looking at: https://github.com/dmlc/tvm/blob/master/docs/langref/relay_type.rst#type-relation

For example we can define an identity relation to be:

It is usually convenient to type operators in Relay by defining a relation specific to that operator that encodes all the necessary constraints on the argument types and the return type. For example, we can define the relation for flatten:

If we have a relation like Broadcast it becomes possible to type operators like add:

I think a line is missing after each colon (:) maybe some code/math snippet that didn't get exported?

@zhiics

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Thanks for reporting this. I think it is probably because of the parsing problem. We need a blank line after ..code-block:: language to correctly parse it. Would you be interested submitting a PR to fix them?

@vmiheer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Oh definitely.

@vmiheer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Added PR #3892. Seems like also docs needed to marked so as to not invoke build pipelines.

@zhiics zhiics closed this Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.