Add count_include_pad support to AvgPool #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
May 17, 2018
topi/python/topi/nn/pooling.py
Outdated
| @@ -42,7 +42,8 @@ def global_pool(data, pool_type, layout="NCHW"): | |||
| return cpp.nn.global_pool(data, POOL_TYPE_CODE[pool_type], layout) | |||
|
|
|||
|
|
|||
| def pool(data, kernel, stride, padding, pool_type, ceil_mode=False, layout="NCHW"): | |||
| def pool(data, kernel, stride, padding, pool_type, ceil_mode=False, layout="NCHW", | |||
There was a problem hiding this comment.
when there are multiple lines, let us break it into one argument per line
tqchen
requested changes
May 17, 2018
topi/include/topi/nn/pooling.h
Outdated
| if (count_include_pad) { | ||
| return tsum(output) / (kernel_height * kernel_width); | ||
| } else { | ||
| auto h_start = output[height_axis] * stride_height - padding_height; |
There was a problem hiding this comment.
prefer Expr to auto, when we know the type and can type it out easily
tqchen
approved these changes
May 17, 2018
|
Thanks for the contribution! this is merged |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
* Add count_include_pad support to AvgPool * Fix python_cpp/test_topi_pooling.py * Change auto to explicitly type, and fix format.
grwlf
pushed a commit
to grwlf/tvm
that referenced
this pull request
Aug 8, 2018
* Add count_include_pad support to AvgPool * Fix python_cpp/test_topi_pooling.py * Change auto to explicitly type, and fix format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed #1144
I confirmed same result as pytorch using following code:
https://gist.github.com/nishi-t/f1c283f176b073b038338dc2ff044ecf