Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM CodeGen] Solve LLVM CodeGen br instruction accept not-i1 type issue #2381

Merged
merged 2 commits into from Jan 8, 2019
Merged

[LLVM CodeGen] Solve LLVM CodeGen br instruction accept not-i1 type issue #2381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af1a8be
Solve LLVM CodeGen br instruction accept not i1 type issue
FrozenGene Jan 7, 2019
ae1061c
Add parentheses to fix gcc warning error
FrozenGene Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/pass/rewrite_unsafe_select.cc
View file
Open in desktop
Expand Up @@ -95,8 +95,10 @@ class UnsafeSelectRewriter : public IRMutator {
Expr expr = IRMutator::Mutate_(op, e);
op = expr.as<Select>();
UnsafeExprDetector unsafe;
if (unsafe.VisitExpr(op->true_value) ||
unsafe.VisitExpr(op->false_value)) {
bool cond_is_scalar_bool = op->condition.type().is_bool() && op->condition.type().is_scalar();
if ((unsafe.VisitExpr(op->true_value) ||
unsafe.VisitExpr(op->false_value)) &&
cond_is_scalar_bool) {
return Call::make(
op->type,
intrinsic::tvm_if_then_else,
Expand Down