Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exact tree training does not seem to colsample bynode #10076

Open
oOTWK opened this issue Feb 26, 2024 · 2 comments
Open

exact tree training does not seem to colsample bynode #10076

oOTWK opened this issue Feb 26, 2024 · 2 comments

Comments

@oOTWK
Copy link
Contributor

oOTWK commented Feb 26, 2024

https://github.com/dmlc/xgboost/blob/master/src/tree/updater_colmaker.cc#L477
FindSplit() enumerates all splits of all nodes in the same depth in parallel. In this function, column_sampler_->GetFeatureSet(depth); is only called once at the beginning. Then, wouldn't it use the same set of features per depth?

@trivialfis
Copy link
Member

Thank you for looking into it, we will explicitly disable the feature for the exact method for now and refine the implementation in later releases.

@oOTWK
Copy link
Contributor Author

oOTWK commented Mar 3, 2024

Thank you for your support always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants