Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Remove Python Rabit Tracker #4781

Closed
thesuperzapper opened this issue Aug 16, 2019 · 3 comments · Fixed by #10112
Closed

[jvm-packages] Remove Python Rabit Tracker #4781

thesuperzapper opened this issue Aug 16, 2019 · 3 comments · Fixed by #10112

Comments

@thesuperzapper
Copy link
Contributor

Given we have the opportunity to make some breaking changes in 1.0, I think we should remove the python based Rabit tracker, and only use the Scala based one. The reason for this is the Scala one has many more features, with things like timeouts.

Here are some links:

At very least, we should default to the Scala one (given how much better it is) as a breaking change in 1.0.

@CodingCat
Copy link
Member

I don’t think we should default to scala one which is much less battle tested

For timeout feature, we have implemented in spark layer where the application will fail if it cannot get enough resources within the given period

@thesuperzapper
Copy link
Contributor Author

@CodingCat in my experience, with issue 4628#issuecomment-510367032, the python tracker will just hang forever. But the Scala tracker will actually time out (Regardless of what we decide, we should investigate the 60sec issue)

@trivialfis
Copy link
Member

Or can we port it into C++ and deprecate both?

@trivialfis trivialfis added this to 2.0 TODO in 2.0 Roadmap via automation Apr 16, 2022
@trivialfis trivialfis moved this from 2.0 TODO to Need prioritize in 2.0 Roadmap Mar 17, 2023
@trivialfis trivialfis removed this from Need prioritize in 2.0 Roadmap Sep 4, 2023
@trivialfis trivialfis added this to To do in 2.1 Roadmap via automation Sep 4, 2023
@trivialfis trivialfis added this to To Do in Network Sep 4, 2023
2.1 Roadmap automation moved this from To do to Done May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Network
To Do
Development

Successfully merging a pull request may close this issue.

3 participants