Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No possibility to read 'old' XGBoost binary files after #4763 #5611

Closed
ShvetsKS opened this issue Apr 27, 2020 · 2 comments
Closed

No possibility to read 'old' XGBoost binary files after #4763 #5611

ShvetsKS opened this issue Apr 27, 2020 · 2 comments

Comments

@ShvetsKS
Copy link
Contributor

In PR #4763 the number of fields was extended(change line: https://github.com/dmlc/xgboost/pull/4763/files#diff-95d8126e28130173959c24f455e01a05R42)

It leads to a problem when user is reading saved XGBoost binary file by version of library before #4763 PR.
CHECK_EQ(field_cnt, kNumField) << "Wrong number of fields";

Is it expected behavior? Should we introduce possibility to read 'old' XGBoost binary files?

example:
dtrain = xgb.DMatrix('dtrain_2.bin') # 'dtrain_2.bin' was saved on commit #5437, and no possibility to read this file on #4763

@trivialfis
Copy link
Member

It's was decided 1.0 should make this change for future extensibility, and we don't want to maintain any redundant code. So it's a breaking change.

@ShvetsKS
Copy link
Contributor Author

@trivialfis Thanks for fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants