-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong relocatable package in dmlc_core #6739
Comments
I think you need to open a PR on dmlc-core: https://github.com/dmlc/dmlc-core/tree/main Then we can update the submodule on xgboost. |
@trivialfis sure, i will do it on the dmlc_core |
@trivialfis I think there are some issues due to doxygen version changes, perviously it was 1.8, now is updated to 1.9.1 and build machine complaint on doc/Doxyfile (this file is formatted based on v1.8.8) config of COLS_IN_ALPHA_INDEX fix can be done in 2way, either
|
@trivialfis Based on #6734, i further found out the generated package /<install>/lib/cmake/DMLCTargets.cmake has the similar issues.
https://github.com/dmlc/dmlc-core/blob/f0ff3146705e27ac2b1e6081fa0983a8a6fda72d/CMakeLists.txt#L171
For this changes, which branch of the dmlc-core i should targeted for PR, then i can further PR the ref git submodule on the xgboost repo?
The text was updated successfully, but these errors were encountered: