Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R xgboost wrapper doesn't pass maximize parameter to xgb.train #916

Closed
ielbert opened this issue Mar 5, 2016 · 5 comments
Closed

R xgboost wrapper doesn't pass maximize parameter to xgb.train #916

ielbert opened this issue Mar 5, 2016 · 5 comments

Comments

@ielbert
Copy link

ielbert commented Mar 5, 2016

R package xgboost version 0.4-3:

xgboost function takes maximize parameter but does not pass it to xgb.train:
Line from xgboost:
bst <- xgb.train(params, dtrain, nrounds, watchlist, verbose = verbose,
print.every.n = print.every.n, early.stop.round = early.stop.round)

xgb.train then complains:
Error in xgb.train(params, dtrain, nrounds, watchlist, verbose = verbose, :
Please set maximize to note whether the model is maximizing the evaluation or not.

@khotilov
Copy link
Member

It was fixed in August b0be833

@ielbert
Copy link
Author

ielbert commented May 12, 2016

The xgboost_0.4-3.tar.gz at CRAN seems to still have this issue with maximize in xgboost.R

@thirdwing
Copy link
Member

@ielbert Can you try the drat repo version?

install.packages("drat", repos="https://cran.rstudio.com")
drat:::addRepo("dmlc")
install.packages("xgboost", repos="http://dmlc.ml/drat/", type="source")

@rwarnung
Copy link

rwarnung commented Sep 6, 2016

I see the same problem in the current version on CRAN, which I use via mlr. But the drat repo version works! Thanks!

@ielbert
Copy link
Author

ielbert commented Sep 6, 2016

Yes, the problem is still there. I just hot-patch the function on the fly.

On Sep 6, 2016, at 4:45 AM, Richard Warnung notifications@github.com wrote:

I see the same problem in the current version on CRAN, which I use via mlr.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants