Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetTagList function bug? #5

Closed
MarcosZornitta opened this issue Mar 17, 2017 · 4 comments
Closed

GetTagList function bug? #5

MarcosZornitta opened this issue Mar 17, 2017 · 4 comments

Comments

@MarcosZornitta
Copy link

I found a little bug in the 'GetTagList' function ... the taglist is never emptied, so when the function is called twice or more (for the same PLC), it adds the tags that are already in the list, again.
So to fix this I had to access the global list and empty it every time the function is called.

Nothing too disturbing, but ...

@MarcosZornitta MarcosZornitta changed the title GetTagList bug? GetTagList function bug? Mar 17, 2017
@dmroeder
Copy link
Owner

Good catch, I'll get this fixed tonight. Thanks for reporting.

@dmroeder
Copy link
Owner

I pushed out a fix for that one.

@MarcosZornitta
Copy link
Author

You need to empty the ProgramNames list as well, or the error will continue for all tags outside the scope of the controller.

self.Offset = 0
del taglist[:]
del programNames[:]

@dmroeder
Copy link
Owner

You're right. The program I tested didn't have program scoped tags so I missed it. I'll get that fixed tonight. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants