Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename php container to app? #5

Closed
schmunk42 opened this issue Aug 31, 2017 · 1 comment
Closed

rename php container to app? #5

schmunk42 opened this issue Aug 31, 2017 · 1 comment
Milestone

Comments

@schmunk42
Copy link
Member

Since it contains the "whole" app including PHP and nginx.

@schmunk42 schmunk42 added this to the 5.2.0 milestone Aug 31, 2017
@handcode
Copy link
Member

Generally, I don't like "app" as a name, because nowadays everything is called "app".

In this particular case we talk about the PHP/Web container of the application stack, which consists of php, nginx, db, redis,..... So I find the name PHP appropriate and see no reason to change it ; -)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants