Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix up of standalone and format tokens for luxon #31

Closed
pomadin opened this issue Feb 28, 2019 · 7 comments
Closed

Mix up of standalone and format tokens for luxon #31

pomadin opened this issue Feb 28, 2019 · 7 comments
Labels
good first issue Good for newcomers luxon needs work 💪 Need some work

Comments

@pomadin
Copy link
Contributor

pomadin commented Feb 28, 2019

Hi,

It seems that for @date-iu/luxon you have setup formats without taking into considearion the token difference .

So i have found the following formats in sources

  public yearMonthFormat = "MMMM yyyy";
  public dateFormat = "LLLL dd";

I would expect the formats

  public yearMonthFormat = "LLLL yyyy"; // standalone token for month as it has no correlation with a day
  public dateFormat = "MMMM dd"; // format token for month as it should correlate with day

Or am I wrong in my expectations?

@dmtrKovalenko
Copy link
Owner

You are right I suppose...
We need to change it.

@pomadin
Copy link
Contributor Author

pomadin commented Feb 28, 2019

Just to add one more proof
image
It's window calendar with RU locale, there is "LLLL yyyy" and "dd MMMM yyyy" formats in terms of luxon.

@dmtrKovalenko dmtrKovalenko added luxon Needs work Needs some bunch of work to resolve needs work 💪 Need some work good first issue Good for newcomers and removed Needs work Needs some bunch of work to resolve labels Mar 1, 2019
@pomadin
Copy link
Contributor Author

pomadin commented Apr 15, 2019

Hi, any news on the subj? I could add a pull request on it.

@dmtrKovalenko
Copy link
Owner

Would be cool

@pomadin
Copy link
Contributor Author

pomadin commented Apr 16, 2019

OK, I did. Please, let me know if I need to update something.

BTW, I faced an effort to run test on windows platform due to TZ parametrization.

@pomadin
Copy link
Contributor Author

pomadin commented Apr 17, 2019

Do you have a plan to release the fix?

@dmtrKovalenko
Copy link
Owner

Released in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers luxon needs work 💪 Need some work
Projects
None yet
Development

No branches or pull requests

2 participants