Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scribble instrumentation metadata for a Fuzz feature #246

Merged
merged 1 commit into from Mar 11, 2021

Conversation

blitz-1306
Copy link

@blitz-1306 blitz-1306 commented Mar 10, 2021

Changes

  • Tweaked ScribbleMixin to use --instrumentation-metadata-file option of Scribble and store metadata at path of SCRIBBLE_ARMING_META_FILE constant (for now it is .scribble-arming.meta.json in the CWD). Arming is generating the metadata file. Disarming will remove it.
  • Introduced ScribbleMixin.get_arming_instr_meta() static method for an convenient access to the generated metadata file contents in other classes.
  • Tweaked fuzz_run to add (if present) data from ScribbleMixin.get_arming_instr_meta() to the submission payload.

Notes

I guess it would be better to add a CLI option to override output location for a generated metadata. The current value (.scribble-arming.meta.json in constant SCRIBBLE_ARMING_META_FILE) can be used as a default.

Related links

Regards.

@blitz-1306 blitz-1306 marked this pull request as draft March 11, 2021 09:42
@joaosantos15 joaosantos15 marked this pull request as ready for review March 11, 2021 10:58
@joaosantos15 joaosantos15 merged commit 65fc5bb into feat/fuzz Mar 11, 2021
@blitz-1306 blitz-1306 deleted the feat/fuzz-scribble-meta branch March 11, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants