Add support for Scribble instrumentation metadata for a Fuzz feature #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ScribbleMixin
to use--instrumentation-metadata-file
option of Scribble and store metadata at path ofSCRIBBLE_ARMING_META_FILE
constant (for now it is.scribble-arming.meta.json
in the CWD). Arming is generating the metadata file. Disarming will remove it.ScribbleMixin.get_arming_instr_meta()
static method for an convenient access to the generated metadata file contents in other classes.fuzz_run
to add (if present) data fromScribbleMixin.get_arming_instr_meta()
to the submission payload.Notes
I guess it would be better to add a CLI option to override output location for a generated metadata. The current value (
.scribble-arming.meta.json
in constantSCRIBBLE_ARMING_META_FILE
) can be used as a default.Related links
Regards.