New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fuzz #249
Feat/fuzz #249
Conversation
…tion during mythx fuzz arm
Add support for Scribble instrumentation metadata for a Fuzz feature
feat: add rpc_url and faas_url as config file options feat: create and start campaign with fuzz run command feat: print url with faas frontend report link
refactor faas api interaction
Fuzzing ide generics
Adds tests to fuzz run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. A few suggestions and questions.
:param remap_import: List of import remappings to pass on to solc | ||
:param solc_version: The solc version to use for Solidity compilation | ||
""" | ||
analyze_config = ctx.get("analyze") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering why do we stick to ctx.get("analyze") and analyze_config while we should be in fuzz context. Is there a real reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, some properties are defined under the "analyze" key. I don't think we should duplicate them under the fuzz key. So I would just keep it like that. I'll just change the "targets" to be fetched from the "fuzz" key, since the user might want different targets for mythx scans and fuzzing.
@offset.setter | ||
def offset(self, value: int) -> None: | ||
value = int(value) | ||
if value <= 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we really restrict assigning 0
for offset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmuhs made this so we'll have to wait for the reply
@length.setter | ||
def length(self, value: int) -> None: | ||
value = int(value) | ||
if value <= 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we really restrict assigning 0
for length?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmuhs made this so we'll have to wait for the reply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test: increase test coverage of fuzz run command
Tweak feat/fuzz to follow changes
Hardhat integration
feat: feature support for hardhat
Feat/fuzz map original source
feat: adds --dry-run flag
feat: add api_key as config file parameter
update default faas url
Feat/fuzz truffle
This PR implements the Fuzz commands, with the
arm
,disarm
andrun
sub-comands.