Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.4 new message: No suitable constructor could be found. #1044

Closed
CrystallDEV opened this issue Dec 26, 2020 · 0 comments
Closed

1.16.4 new message: No suitable constructor could be found. #1044

CrystallDEV opened this issue Dec 26, 2020 · 0 comments
Assignees
Milestone

Comments

@CrystallDEV
Copy link

Describe the bug
It seems like ProtocolLib is unable to find the matching constructor for delivering a message to a player. I think this is caused by 1.16.4 adding UUIDs to each message delivered. I tried last week to find a fix for the error and noticed that ChatExtensions#getJsonFormatConstructor is trying to look for a packet constructor with 1 parameter, while the constructor I was able to find requires 3. Changing this fixed the initial error, but caused other errors. I think these are caused by the messages not correctly being built together to match the new constructor.

Im sadly missing the time currently to fix this, so maybe you guys can assist or continue where I stopped.

To Reproduce
Steps to reproduce the behavior:
My PlayerNPCLibrary is using protocollib to spawn in fake player npcs using several packets which are devliered through protocollib (If needed: The code of the library is public in my profile). After logging in for the first time the following error occurs once: https://pastebin.com/yHPJbQJj

Relogging does not trigger the error again and causes the library to work normally.

Version Info
https://pastebin.com/VPVGv9qm

@dmulloy2 dmulloy2 self-assigned this Dec 26, 2020
@dmulloy2 dmulloy2 added this to the 4.6.0 milestone Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants