-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest ProtocolLib does not work with Paper 1.20.2 while earlier ones does. #2593
Comments
Are you using TCPShield or any another plugins? Looks like it's some plugins incompatibility in ProtocolLib 1.5.1+. You can test it without any plugins, just ProtocolLib? I have the same issue with ProtocolLib 5.1.1-SNAPSHOT-673 and TCPShield 2.6.1 on Paper version git-Paper-260 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: 1865625) I tested some more dev builds. Build 669 have no this problem, but 670 already have. So, looks problem appears after this commit: af33a2a I also want to clarify that no any errors occur in the server and client logs on startup an logging. TCPShield releases can be found here: https://github.com/TCPShield/RealIP/releases |
someone can send link to ProtocolLib SNAPSHOT 669? Version 1.20.2 |
I do not use neither TCPShield not other plugins. I tested AdvancedNMotd being the only plugin at the server excluding ProtocolLIB before writing this issue.
|
Issue appears when using AdvancedNMotd too. So, if AdvancedNMotd isn't installed there are no any problems with ping or joining server. I checked out the both plugins code (TCPShield and AdvancedNMotd) and find out that this is what is causing the ping and server connection problems. Is just enough to register packet adapter with packet PacketType.Handshake.Client.SET_PROTOCOL:
There are no any errors in the console, but the TCPShield registration: https://github.com/TCPShield/RealIP/blob/bb7511d37f915ea1b8416ac24dd8564b9d3d0e20/src/main/java/net/tcpshield/tcpshield/bukkit/protocollib/handler/ProtocolLibHandshakeHandler.java#L18 AdvancedNMotd registration: https://github.com/NamerPRO/AdvancedNMotd/blob/b764e435696ca9b5fc0a0ef1a77e417261e9dee2/src/ru/namerpro/AdvancedNMotd/Bukkit/Main.java#L61 |
Describe the bug
Motd is not set via ProtocolLib Snapshot 5.1.1-SNAPSHOT-673 on Paper 1.20.2 (# 249) server and a player cannot join server while with ProtocolLib 5.1.1-SNAPSHOT-669 same code works fine. There are no errors in console.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Motd must be set and player must have an access to join server.
Screenshots
![iimg](https://private-user-images.githubusercontent.com/90556614/278816009-947a460b-e717-4b64-b3ee-a1bbeb866985.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjQzMjIsIm5iZiI6MTcxOTQyNDAyMiwicGF0aCI6Ii85MDU1NjYxNC8yNzg4MTYwMDktOTQ3YTQ2MGItZTcxNy00YjY0LWIzZWUtYTFiYmViODY2OTg1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE3NDcwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTllMTJhNWI1NmZlNWJmNGIxOTM2NGIyZDg5NWM4NTRlNDQ2YWYxNDg2MjU5NzViODdlZDFkZTJhNzQyYzQ5NjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.yE3R2ggQKEuYUdH8frr2jNiNagTyeu7S5ZKXEc3ZKQs)
When used with ProtocolLib SNAPSHOT 673 (latest at the moment of writing report):
When used with ProtocolLib SNAPSHOT 669:
![iimg](https://private-user-images.githubusercontent.com/90556614/278815911-d2372061-875f-4518-94d2-95d4420b4383.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjQzMjIsIm5iZiI6MTcxOTQyNDAyMiwicGF0aCI6Ii85MDU1NjYxNC8yNzg4MTU5MTEtZDIzNzIwNjEtODc1Zi00NTE4LTk0ZDItOTVkNDQyMGI0MzgzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE3NDcwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE0MTkzYThiMTEyODM2NTMzMDhiY2RjMTc0NWEzOGQ4MjlkMGRhODI3OTI1NGU1YzNjOGM2ZmU0ZjBkZTI5ODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.JgcfSy9g58cMATuUZyjpEcF5VIercKqcajO-lNgHITY)
Version Info
https://pastebin.com/j1vhfvL6
The text was updated successfully, but these errors were encountered: