Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.2 - STEER_VEHICLE mapped to ServerboundPongPacket #2818

Open
1 task done
LoneDev6 opened this issue Feb 26, 2024 · 4 comments
Open
1 task done

1.20.2 - STEER_VEHICLE mapped to ServerboundPongPacket #2818

LoneDev6 opened this issue Feb 26, 2024 · 4 comments

Comments

@LoneDev6
Copy link

LoneDev6 commented Feb 26, 2024

  • This issue is not solved in a development build

Describe the bug
Seems a bug of ProtocolLib 5.2.0-SNAPSHOT-679 and 1.20.2.
For some reason PacketType.Play.Client.STEER_VEHICLE.getPacketClass() returns ServerboundPongPacket instead of PacketPlayInSteerVehicle.
image

To Reproduce
Steps to reproduce the behavior:

  • spawn a tamed horse: /summon horse ~ ~ ~ {Tame:1, SaddleItem:{id:saddle,Count:1}}
  • ride it
  • listen for the packet
  • the packet event is not called
        ProtocolLibrary.getProtocolManager().addPacketListener(new PacketAdapter(
                PacketAdapter.params()
                        .plugin(plugin)
                        .listenerPriority(ListenerPriority.HIGHEST)
                        .types(PacketType.Play.Client.STEER_VEHICLE)
        )
        {
            @Override
            public void onPacketReceiving(PacketEvent e)
            {
                if (e.isCancelled() || e.isPlayerTemporary())
                    return;

                Player player = e.getPlayer();
//.....

Expected behavior
STEER_VEHICLE to be called

Screenshots

Version Info
https://pastebin.com/uwgzyVQK

@jamydariels
Copy link

please fix

@LoneDev6
Copy link
Author

LoneDev6 commented Jun 6, 2024

Any news?

@LoneDev6 LoneDev6 changed the title STEER_VEHICLE mapped to ServerboundPongPacket in 1.20.2 1.20.2 - STEER_VEHICLE mapped to ServerboundPongPacket Jun 6, 2024
@dmulloy2
Copy link
Owner

dmulloy2 commented Jun 6, 2024

will take a look today

@jamydariels
Copy link

i'm using build 689 and i think it is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants