NET-111-fixing-flaky-tests #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I see the CI uses |
JCSanPedro
reviewed
Apr 5, 2022
test/keys.json
Outdated
| {"publicKey":"PHAo3MImPpuEhb8XZahF22Qk_J16XlTIAouOiRaFD-U","privateKey":"UxuhttBGSOBKEJxDsFY_0ypD1n4S4-gGOm56LQ1UfH08cCjcwiY-m4SFvxdlqEXbZCT8nXpeVMgCi46JFoUP5Q"}, | ||
| {"publicKey":"qOXEjFdugVUycDSAiPvZdwEd0T2xN2UW7c0xxUuvolc","privateKey":"6yNkzVxrq5zFDukUXGnqd5TF7y7P7RRh_KokP6tLE9So5cSMV26BVTJwNICI-9l3AR3RPbE3ZRbtzTHFS6-iVw"}, | ||
| {"publicKey":"y8jnrlMMwqxkWraxr40-xVJfWyszdh4Cxwa4fI-YxaA","privateKey":"IzqVzUrDx_fzWb-B8uZr3N0YMnkB2aHGWtv0Jpqp4R7LyOeuUwzCrGRatrGvjT7FUl9bKzN2HgLHBrh8j5jFoA"} | ||
| ] |
There was a problem hiding this comment.
Instead of storing this json file, you can just quickly generate 1000 keys in memory using the same mnemonic each time.
Something like
const mnemonic = "search topple trouble similar sorry just around connect hello range predict ahead";
const accs = [];
for (let i = 0; i < 1000; i++) {
accs.push(ethers.Wallet.fromMnemonic(mnemonic, `m/44'/60'/0'/${i}`));
}
There was a problem hiding this comment.
Then it's easier to change the number of keys to use
Altered test key generation method from pure random to be from mnemonic.
JosiahBull
force-pushed
the
NET-111-goodness-of-fit-flaky-test
branch
from
bb059f5
to
ace214a
Compare
JosiahBull
changed the title
JCSanPedro
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed flaky tests:
should distribute scan results amongst stakees proportionally - all equalshould distribute scan results amongst stakees proportionally - varied stake amountsPrevious random generation method had a failure rate of 6.44%. New method does not fail.
Test Logs: output.zip