Tidying up GridField top level view (#113)

* Update screenshot, remove elements folder in favour of namespaces. * Update to BEM standard and remove namespace strip
silverstripe · Oct 17, 2017 · 54a54b4 · 54a54b4
1 parent 0c3f038
commit 54a54b4
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -178,9 +178,6 @@ After setting up your SolrSearchIndex, run `sake dev/tasks/Solr_Configure`.
 
 ![Overview](docs/images/overview.png)
 
-![Detail](docs/images/detail.png)
-
-
 ## Versioning
 
 This library follows [Semver](http://semver.org). According to Semver, you will be able to upgrade to any minor or patch version of this library without any breaking changes to the public API. Semver also requires that we clearly define the public API for this library.

diff --git a/css/elemental-admin.css b/css/elemental-admin.css
@@ -82,28 +82,33 @@ td.col-ElementSummary {
 .elementalpreview {
     position: relative;
     padding: 0 0 0 50px;
-    min-height: 45px;
+    min-height: 35px;
 }
     .elementalpreview h2 {
         margin: 0;
+        font-weight: 400;
+        -webkit-font-smoothing: antialiased;
     }
 
     .elementalpreview small {
         font-size: 13px;
         opacity: 0.8;
     }
-    .elementalpreview--icon {
+
+    .elementalpreview__detail {
+        padding-top: 5px;
+    }
+
+    .elementalpreview__icon {
         position: absolute;
-        top: 5px;
         left: 0px;
-        background: #f7f7f7;
         border-radius: 2px;
         height: 35px;
         width: 35px;
         display: flex;
         align-items: center;
         justify-content: center;
     }
-        .elementalpreview--icon img {
+        .elementalpreview__icon img {
             opacity: 0.4;
         }
diff --git a/docs/images/detail.png b/docs/images/detail.png
diff --git a/docs/images/overview.png b/docs/images/overview.png
diff --git a/src/Models/BaseElement.php b/src/Models/BaseElement.php
@@ -495,13 +495,15 @@ public function getAnchor()
         }
 
         $anchorTitle = '';
+
         if (!$this->config()->disable_pretty_anchor_name) {
             if ($this->hasMethod('getAnchorTitle')) {
                 $anchorTitle = $this->getAnchorTitle();
             } elseif ($this->config()->enable_title_in_template) {
                 $anchorTitle = $this->getField('Title');
             }
         }
+
         if (!$anchorTitle) {
             $anchorTitle = 'e'.$this->ID;
         }

diff --git a/templates/DNADesign/Elemental/Models/BaseElement_EditorPreview.ss b/templates/DNADesign/Elemental/Models/BaseElement_EditorPreview.ss
@@ -1,12 +1,8 @@
 <div class="elementalpreview">
-    <div class="elementalpreview--icon">$Icon</div>
+    <div class="elementalpreview__icon">$Icon</div>
 
-    <div class="elementalpreview--detail">
-        <small>$Type</small>
-
-        <% if Title %>
-            <h2>$Title</h2>
-        <% end_if %>
+    <div class="elementalpreview__detail">
+        <h2><% if Title %>$Title <% end_if %><small>$Type</small></h2>
 
         <% if Summary %>
             <p>$Summary</p>