Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Reorder text checkbox group and apply Reactstrap styles #488

Merged
merged 1 commit into from Nov 1, 2018
Merged

FIX Reorder text checkbox group and apply Reactstrap styles #488

merged 1 commit into from Nov 1, 2018

Conversation

raissanorth
Copy link
Contributor

Fixes #486 by introducing a custom TextCheckboxGroup component and making use of styling available through Reactstrap.

Added a .scss file to overwrite the styling applied through .form-check

@NightJar
Copy link
Contributor

NightJar commented Nov 1, 2018

Oh dear.
🐝 🎩

And I should see "Title (displayed if checked)" # >DNADesign\Elemental\Tests\Behat\Context\FeatureContext::assertPageContainsText()
The text "Title (displayed if checked)" was not found anywhere in the text of the current page.

@ScopeyNZ ScopeyNZ merged commit b5beb91 into silverstripe:master Nov 1, 2018
@ScopeyNZ ScopeyNZ deleted the pulls/4.0/check-one-two-three branch November 1, 2018 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightJar NightJar NightJar approved these changes

Assignees
No one assigned
Labels
affects/v4 type/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raissanorth @NightJar @ScopeyNZ