Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draine 21 PAH emissivities could be included for all simulations #192

Open
dnarayanan opened this issue Jul 27, 2022 · 0 comments
Open

Draine 21 PAH emissivities could be included for all simulations #192

dnarayanan opened this issue Jul 27, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dnarayanan
Copy link
Owner

I had been thinking that we could only include the new Draine models for simulations that have a grain size distribution in them (like Smuggle; some flavors of Gizmo etc.). But I don't think this is right -- there are also files in the dataverse that are based on Draine & Hensley precomputed size distributions. We can use those and still take advantage of the local ISRF in computing the PAH emissivities which will be more accurate than the current Robitaille/MW models.

Steps in order to do this:

[1] first and foremost the ISRF fork of Hyperion needs to be PR'd and merged into main so that it's more easily accessible for everyone by default.

[2] I think really the only thing that will change after that from the full PAH (size distribution) model Is that, pending some different parameters keywords, we can have a different file/io routine that reads into a different kind of PAH object that doesn't have sizes. The the pah luminosity function won't need to dot product into the size distribution but just take fractional contributions from beta_nnls.

Anyways, a feature not a bug, and something that should be doable fairly easily once the more complex PAH model is stabilized.

@dnarayanan dnarayanan added the enhancement New feature or request label Jul 27, 2022
@dnarayanan dnarayanan self-assigned this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant