Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no PAHs in the enzo_tributary #69

Open
dnarayanan opened this issue Mar 16, 2020 · 3 comments
Open

no PAHs in the enzo_tributary #69

dnarayanan opened this issue Mar 16, 2020 · 3 comments

Comments

@dnarayanan
Copy link
Owner

No description provided.

@anchwr
Copy link
Contributor

anchwr commented Jan 14, 2021

I've implemented this locally by adding a "multiply by a scalar" function to hyperion's AMRGridView class and then largely copying the PAH implementations from the other tributaries. Would it be helpful for me to try posting to the hyperion github to request this change?

@dnarayanan
Copy link
Owner Author

ah interesting! so within pd I would very much welcome a pull request and thanks so much for having done this. (to be honest I can't remember why I didn't do it myself when setting up the Enzo front end...I suspect I saved it for later to deal with then just never did).

but, I'm not sure I understand what you did within hyperion? is this scalar multiplication to mimic the energy of the CMB?

@anchwr
Copy link
Contributor

anchwr commented Jan 19, 2021

Sorry - that was a very ambiguous description! I haven't tried to implement any of the CMB stuff yet. I implemented the scalar multiplication in hyperion so that I could multiply the AMR dust grid by the different PAH dust grain fractions - similar to

m.add_density_grid(dustdens*frac[size],d,specific_energy=specific_energy)

I couldn't figure out a clean way to do this for the Enzo tributary without making a change to hyperion's AMRGridView class, since the dust grid read in by yt is an instance of this and it couldn't be multiplied by a scalar. I thought this might be why PAHs hadn't been implemented for Enzo yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants