Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dustsmoothed masses not general #72

Open
dnarayanan opened this issue Apr 6, 2020 · 0 comments
Open

dustsmoothed masses not general #72

dnarayanan opened this issue Apr 6, 2020 · 0 comments

Comments

@dnarayanan
Copy link
Owner

this is pretty minor, but in (e.g. gadget2pd there's some inefficiencies that look like this:

        if yt.__version__ == '4.0.dev0':
            return (data.ds.parameters['octree'][('PartType0','Dust_Masses')])

        else:
            return (data.ds.arr(data[("deposit", "PartType0_sum_Dust_Masses")].value, 'code_mass'))


    def _li_ml_dustsmoothedmasses(field,data):
        if yt.__version__ == '4.0.dev0':
            return (data.ds.parameters['octree'][('PartType0', 'li_ml_dustmass')])
        else:
            return (data.ds.arr(data[("deposit", "PartType0_sum_li_ml_dustmass")].value, 'code_mass'))

i.e. the dustsmoothedmasses are either in this situation only good for manual or li_ml, and not generalized. we should just generalize these to be dustsmoothedmasses and encapsulate whatever choice we've made. this is unnecessarily clunky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant