You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
3dstool produces errors and exits in an error state when extracting a cxi file if not extracting the ExeFS. The content is still extracted successfully, but the error state causes issues for scripts which rely on exit state to determine extraction success. No errors are produced if the ExeFS is extracted as well, even if to NUL or /dev/null.
Steps to Reproduce:
Extract any contents from a cxi file excluding the ExeFS.
eg. 3dstool -xvtf cxi "test.cxi" --header header.bin --extendedheader exheader.bin
Expected Results:
Selected contents are extracted without error.
Actual Results:
Selected contents are extracted, but program produces errors: ERROR: open file failed and ERROR: extract file failed
Additional Info:
It appears that m_sExeFsFileName is not checked to contain a path prior to an attempted file open (ncch.cpp:189), causing these errors.
Example of extract with errors:
E:\Citra\Games>3dstool -xvtf cxi "Pokemon SMD.cxi" --header header.bin --extendedheader exheader.bin
save: header.bin
save: exheader.bin
INFO: logoregion is not extract
INFO: plainregion is not extract
ERROR: open file failed
INFO: romfs is not extract
ERROR: extract file failed
Example of extract without errors:
E:\Citra\Games>3dstool -xvtf cxi "Pokemon SMD.cxi" --header header.bin --extendedheader exheader.bin --exefs exefs.bin
save: header.bin
save: exheader.bin
INFO: logoregion is not extract
INFO: plainregion is not extract
save: exefs.bin
INFO: romfs is not extract
On an unrelated note, would you consider adding a license to this repo? (maybe MIT or zlib?)
The text was updated successfully, but these errors were encountered:
3dstool produces errors and exits in an error state when extracting a cxi file if not extracting the ExeFS. The content is still extracted successfully, but the error state causes issues for scripts which rely on exit state to determine extraction success. No errors are produced if the ExeFS is extracted as well, even if to
NUL
or/dev/null
.Steps to Reproduce:
Extract any contents from a cxi file excluding the ExeFS.
eg.
3dstool -xvtf cxi "test.cxi" --header header.bin --extendedheader exheader.bin
Expected Results:
Selected contents are extracted without error.
Actual Results:
Selected contents are extracted, but program produces errors:
ERROR: open file failed
andERROR: extract file failed
Additional Info:
It appears that
m_sExeFsFileName
is not checked to contain a path prior to an attempted file open (ncch.cpp:189), causing these errors.Example of extract with errors:
Example of extract without errors:
On an unrelated note, would you consider adding a license to this repo? (maybe MIT or zlib?)
The text was updated successfully, but these errors were encountered: