Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded PDFs are corrupted; alldatasheets blocked you? #6

Closed
chanibal opened this issue Jan 11, 2014 · 1 comment
Closed

Downloaded PDFs are corrupted; alldatasheets blocked you? #6

chanibal opened this issue Jan 11, 2014 · 1 comment

Comments

@chanibal
Copy link

When I try to view any datasheet (ex. attiny85), I get an "cannot open PDF file" from my pdf reader. The contents of the pdf downloaded to /sdcard/ATtiny85-20140111-230016.pdf are:

<script type='text/javascript' src='http://ads.supplyframe.com/openads/adjs.php?​
n=544970556&what=zone:448&target=_blank
&taxonomy=/Electronic+Components/​Semiconductors+and+Integrated+Circuits/Microprocessors,+Microcontrollers,+DSPs/​AR​M,+​RISC-Based+Microcontrollers
&term=ATtiny85&exclude=,'>​</script>

(whitespace trimmed, added line breaks)

Tested on motorola xoom 3g, android 4.0.3, not rooted.

Note: didn't build the app from source, but used the binary distribution from http://techblog.vsza.hu/posts/Unofficial_Android_app_for_alldatasheet.com.html; the filename had a name of adsdroid-release-v1.4 and last commit says "bumped version to 1.4", so i guess it's the same (may be mistaken, through).

@dnet dnet closed this as completed in c15dd5a Feb 12, 2014
@dnet
Copy link
Owner

dnet commented Feb 12, 2014

Thanks for the report, and sorry for the delay. When they introduced iframe ads, I used a pretty dumb algorithm to find which one to use (the first one that is a child of a td), and this fragility caught me now, when they added another iframe. With this fix, I tried to look for relative URLs, which should solve the issue for the foreseeable future (as long as the don't start serving ads from local URLs). You can download the APK from https://github.com/dnet/adsdroid/releases/tag/v1.5 and vsza.hu should redirect here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants