Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.4.0: thread 'tokio-runtime-worker' panicked at 'called Option::unwrap() on a None value', bin/dnglab/src/dnggen.rs:144:66 #140

Closed
arbv opened this issue Apr 11, 2022 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@arbv
Copy link

arbv commented Apr 11, 2022

I had problems converting the attached CR3 file. The converted DNG file size is 0 bytes.

artem@zorrobook:~/report$ RUST_BACKTRACE=full dnglab convert ./IMG_4959.CR3 ./IMG_4959.DNG
thread 'tokio-runtime-worker' panicked at 'called `Option::unwrap()` on a `None` value', bin/dnglab/src/dnggen.rs:144:66
stack backtrace:
   0:     0x5613302aca4c - <unknown>
   1:     0x5613302d046c - <unknown>
   2:     0x5613302a5cc5 - <unknown>
   3:     0x5613302ae620 - <unknown>
   4:     0x5613302ae1d5 - <unknown>
   5:     0x5613302aecd4 - <unknown>
   6:     0x5613302ae782 - <unknown>
   7:     0x5613302acef4 - <unknown>
   8:     0x5613302ae719 - <unknown>
   9:     0x56132ffaa9e1 - <unknown>
  10:     0x56132ffaa92d - <unknown>
  11:     0x56132ffe9f44 - <unknown>
  12:     0x56132ffcab4c - <unknown>
  13:     0x56132ffd6a74 - <unknown>
  14:     0x56133004a4d5 - <unknown>
  15:     0x56133000696c - <unknown>
  16:     0x5613300993d5 - <unknown>
  17:     0x56133008d0fe - <unknown>
  18:     0x5613300abfd8 - <unknown>
  19:     0x5613302b2c53 - <unknown>
  20:     0x7f237cb465c2 - start_thread
  21:     0x7f237cbcb584 - __clone
  22:                0x0 - <unknown>
Converted 0/1 files, 1 failed:
   /home/artem/Pictures/raw academy/report/IMG_4959.CR3
Total time: 0.73s

The previous version (0.3.1) produced the usable result, despite lacking support for Canon EF-S 17-55mm f/2.8 IS USM Lens (see #108).

Here is a link to the CR3 file

For some reason Github did not want to accept my CR3 file upload, nor a zip file which included it.

@arbv
Copy link
Author

arbv commented Apr 11, 2022

BTW, the file attached in #108 bug report also triggers the bug.

@cytrinox
Copy link
Contributor

Thanks for your bug report, but I can not reproduce it with current main branch. A lot of code refactoring was done since 0.4 on main. Looks like this is already fixed 😄

@arbv
Copy link
Author

arbv commented Apr 13, 2022

That is great!

Are there any plans to release the next version soon?

Again, thanks for your hard work. You are working on a really missing peace of software!

@cytrinox cytrinox self-assigned this May 19, 2022
@cytrinox cytrinox added this to the 0.5.0 milestone May 19, 2022
@cytrinox cytrinox added the bug Something isn't working label May 19, 2022
@arbv
Copy link
Author

arbv commented May 24, 2022

Just in case: the version from main does not abort, so this one could be closed.

@arbv arbv closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants