Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fake timers in tests #13

Open
dnlup opened this issue Oct 27, 2020 · 2 comments · May be fixed by #18
Open

Use fake timers in tests #13

dnlup opened this issue Oct 27, 2020 · 2 comments · May be fixed by #18

Comments

@dnlup
Copy link
Owner

dnlup commented Oct 27, 2020

Sometimes timer-based tests fail. Maybe using a fake timer would solve this.
@dnlup
Copy link
Owner Author

dnlup commented Oct 28, 2020

I am having trouble with the implementation of the refresh() function of timers. It seems it's not working properly, or I might have missed something in its usage.

Ref: sinonjs/fake-timers#187

Anyway, it seems like they still need to publish the proposed fix.

@dnlup dnlup linked a pull request Oct 28, 2020 that will close this issue
Open
@dnlup
Copy link
Owner Author

dnlup commented Feb 25, 2021 •
edited

We would not need this anymore if #56 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: use fake timers dnlup/agent-11
1 participant
@dnlup