Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raw field in data event object #44

Closed
dnlup opened this issue Aug 7, 2020 · 1 comment · Fixed by #52
Closed

Remove raw field in data event object #44

dnlup opened this issue Aug 7, 2020 · 1 comment · Fixed by #52
Labels
breaking change This will cause a breaking change
Milestone

Comments

@dnlup
Copy link
Owner

dnlup commented Aug 7, 2020

Keeping this field is starting to be cumbersome. Once the set of options for the event loop delay gives the user enough flexibility I think it should be removed.

@dnlup dnlup added the breaking change This will cause a breaking change label Aug 7, 2020
@dnlup
Copy link
Owner Author

dnlup commented Aug 12, 2020

Or, I could add an option to select if the user would like the raw metrics or the computed ones. I'm thinking one would use the computed metrics when monitoring an application in production, and the raw metrics when writing a performance analysis tool.

@dnlup dnlup added this to the Version 2 milestone Aug 12, 2020
@dnlup dnlup linked a pull request Aug 13, 2020 that will close this issue
7 tasks
@dnlup dnlup closed this as completed Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This will cause a breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant