Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json boilerplate #1

Closed
rabeckett opened this issue May 11, 2020 · 0 comments
Closed

json boilerplate #1

rabeckett opened this issue May 11, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@rabeckett
Copy link
Contributor

There appears to be a lot of repetitive json boilerplate (e.g., in properties.cpp), where the json is being constructed manually. This manual conversion is also what caused the bug in the structural delegation property.

Could we create specific classes for the result of each property check and then a superclass for "violation" that contains the common data (property name, etc.)? Then we could use the json library's simple method for converting classes to json:

https://github.com/nlohmann/json#basic-usage
@rabeckett rabeckett added the enhancement New feature or request label May 11, 2020
@rabeckett rabeckett assigned rabeckett and unassigned rabeckett May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rabeckett