Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasets are non-unique #12

Closed
jelu opened this issue Mar 10, 2016 · 1 comment
Closed

Datasets are non-unique #12

jelu opened this issue Mar 10, 2016 · 1 comment
Assignees
@jelu
Labels
bug

Comments

@jelu
Copy link
Member

jelu commented Mar 10, 2016

When configuring datasets the name is not checked for duplicates so you can specify the same named dataset multiple times with the same or different metrics.

@wessels is this a design choice or a bug?
@wessels
Copy link
Member

wessels commented Mar 10, 2016

This sounds like a bug. They should be unique I think.

@jelu jelu self-assigned this Mar 10, 2016
@jelu jelu added the bug label Mar 10, 2016
@jelu jelu closed this as completed in 7a2a67e Mar 14, 2016
jelu added a commit that referenced this issue Mar 14, 2016
@jelu
Merge pull request #15 from jelu/unique_dataset
9e06957 
Fix #12: Add hash for dataset names and check for duplicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jelu jelu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wessels @jelu