Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Cargo.lock #31

Closed
kpcyrd opened this issue Jul 20, 2019 · 1 comment
Closed

Missing Cargo.lock #31

kpcyrd opened this issue Jul 20, 2019 · 1 comment

Comments

@kpcyrd
Copy link

kpcyrd commented Jul 20, 2019

Since this is a binary project it should distribute its Cargo.lock. Some distros depend on it for reproducible builds.

@jedisct1
Copy link
Member

Hi!

I'm not a big fan of having a Cargo.lock file in the source code, rather than a minimum version.

When the project is being compiled, it's nice to have the latest compatible version of all dependencies, rather than aging, possibly insecure or broken (due to changes in the compiler) versions that have been hard-coded in a Cargo.lock file.

This is an executable file, so it doesn't matter much, but with libraries, these Cargo.lock file also tend to require many versions of the exact same sub-dependencies, just because the dependencies includeCargo.lock files generated at different times.

For building reproducible packages, you may want to add this Cargo.lock file.

But I'd prefer to avoid including it in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants