New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None of my sounds seem to work anymore. #56
Comments
Scratch that, sorry. Everything I was trying to post was a jpg. Those all appear to be broken, but the animated gifs I have still work. Going to try converting the jpegs to gifs but you probably still want to take a look at that issue. Maybe "bigger" isn't big enough or something. |
Sorry. Scratch that AGAIN. They're actually not working. They don't give embedded file errors when you try to upload them, but the player doesn't play them. I'll stop being an idiot, wait patiently, and let you try to figure out what's going on. |
Just so you know, I tested them before I uploaded them by dropping them onto the player from my computer and they worked fine. Once uploaded, they didn't work anymore. I tried downloading the file from 4chan after uploading it and then dropping THAT file onto the player from my computer and it didn't work. Hope that helps. Hope I'm not being annoying. Thanks for making this. I'll really shut up now. |
Well it looks like something has changed. There seems to be a new limit on how much data can exist past the end of files. I only tested with .jpg, but it seems that having something the range of 50000-60000 extra bytes will flag it as an embedded image. I would guess something similar for .png and .gif; they might even be removing the extra data like they should have done from the start. As an alternative, stego should probably still work, although it is slightly more laborious to create images with it. |
Tried that and it works like a charm. Thanks for the workaround! I'll use that method for now. Hopefully you'll find a way to get it working so that I can make my anime characters dance in time to anime music again. |
I did some testing with PNG files; here are my results: The filter appears to be turned off entirely for files under 200 KB (204800 bytes). There's still more to test, but if this is any indication, it's probably a reasonably good filter for once. Probably the best way to keep this going is to add pixel-data steganography support to the uploading script. This has already been done here: It's probably time to reconsider #36 as well. |
Honestly I don't know why it doesn't remove the extra data on all image formats instead of just on .gif. If the data can be removed and give the same image by simply truncating anything that isn't needed, I don't see why they even have the "Your image contains embedded whatever" error. At this point, it might be best for a rewrite of the entire thing. It's pretty bloated at this point, the code isn't all that pretty, and it's gone through hell with the numerous revisions 4chan, browser code, and userscript managers. Uncompressed source is 20,000 lines long. Certain features I added I don't even use, like embedding soundcloud/youtube/vimeo in the player itself; I like the pop-up preview when hovering over a link though, that might be worth rewriting into a separate script. Linkification features are redundant now with 4chan-x/inline extension. Especially with how only 1 format is pretty much guaranteed to work anymore, it might be worth it for some completely new stego tools to be written too, replacing the redundancy of having both sound images and video images, when video images are simply sound images with extra functionality. I might check this out at some point when 4cs patch-work starts falling apart. Even .webm without sound would be worth having. The number of .gifs I see that are less than 5 seconds long at about a quarter of the source resolution is astounding. And they are almost always near 3mb. I have no idea why a feature like this isn't natively supported on 4chan. |
Would it be feasible to fix embedding webm in images or adding some sort of functionality to embedding sound in webm somehow? I doubt moot will ever allow sound streams in webms and has a 1:20 limit which sucks |
Did moot finally find a way to kill it? Everything gives me embedded file errors now, be it sounds or videos. Tried making them bigger, but apparently that wasn't the issue either.
The text was updated successfully, but these errors were encountered: