Merge route and prefix attributes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ton31337 Can you catch this branch up to current master? I can see about merging this before release as well. |
ton31337
force-pushed
the
feature/merge_prefix_and_route_attributes
branch
from
1b73615
to
1cec46d
Compare
|
Done. |
|
Sweet, thank you @ton31337! Will merge and make sure you are in the change log. ❤️ |
martinisoft
added a commit
that referenced
this pull request
Jun 17, 2015
…tributes Merge route and prefix attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge prefix and route attributes, because it's absolutely not necessary to have both. It's more understandable to have one attribute like route/prefix instead of two.