Migrate to Chef 12.1+ based resources #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly useful for source installs and the package stuff will get baked in by platform 👍
Not only are they not documented, but they don't appear to be tested either.
The first defined action of a resource is the default action so it's implicit and does not need to be explicit here.
These are replaced by resources now
Also the first 14.04 Ubuntu tests passes.
Somehow I thought this was implied with the cookbook name, but it turns out this is entirely adjustable
Resource name and provides are very similar, but don't perform the same function. We need to give unique resource names for each platform, then go into provides to be specific about the resource it's providing and on which platform it responds to.
Leaving that responsibility to the final user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a massive cleanup and re-write of the cookbook in an effort to modernize it for Chef 12 and beyond. It completely strips down the responsibilities of the cookbook and introduces quite a few breaking changes. Most notably the lack of a source based installation method. Source based installs are not Chef's strong suit and thus prone to plenty of error modes making it exceedingly difficult to test and maintain. Just check out the other PR's changing the hard coded values and attempting to add additional features. Here's a summary of what's changed and the TODO before this PR can be officially reviewed and merged:
Changes:
TODO:
pdns_recursor_serviceresourcespdns_authoritative_installresourcespdns_authoritative_serviceresources