Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deep linking / sub-path parsing #17

Closed
lidel opened this issue Aug 3, 2021 · 1 comment
Closed

Remove deep linking / sub-path parsing #17

lidel opened this issue Aug 3, 2021 · 1 comment
Assignees
Labels
P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Contributor

lidel commented Aug 3, 2021

Concern

iiuc the only reason for parsing sub-paths was special-casing during redirects.

Given that we will be removing that special-casing (#16) there is no reason for DNSLink libraries to care about the value after dnslink=/foo/..

Additionally, the way path is parsed in dnslink-std/test v0.9.0 forces everyone to use URL abstractions (pathname, search are URL components that could conflict with characters used as content identifiers)

Ask

Remove sub-path parsing and keep any sub-path as part of the identifier:

dnslink=/<namespace>/<identifier>

## Example
dnslink=/ipfs/QmX2KTMXiUb6tHTMS1JynhyQaL9qoj6uf1SLzHPhzGNnDv/go-ipfs/v0.9.1
namespace=ipfs
identifier=QmX2KTMXiUb6tHTMS1JynhyQaL9qoj6uf1SLzHPhzGNnDv/go-ipfs/v0.9.1
@lidel lidel mentioned this issue Aug 3, 2021
2 tasks
@lidel lidel added the P0 Critical: Tackled by core team ASAP label Aug 3, 2021
@martinheidegger
Copy link
Contributor

Closed by 4c6ffdc8624d75055ec43e72799059a1319ee0ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

2 participants